Retire RSpec/InvalidPredicateMatcher #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping. For 2.0, after we bump to RuboCop 1.0? |
|
👍 But we cannot merge yet. |
|
@pirj I’ll rebase this pull request. |
bquorning
force-pushed
the
reture-invalid-predicate-cop
branch
from
a73db78
to
f2d59bb
Compare
bquorning
approved these changes
Oct 22, 2020
CvX
added a commit
to discourse/rubocop-discourse
that referenced
this pull request
Nov 6, 2020
Removed from rubocop-rspec in rubocop/rubocop-rspec#940
CvX
added a commit
to discourse/rubocop-discourse
that referenced
this pull request
Nov 6, 2020
(Removed from rubocop-rspec in rubocop/rubocop-rspec#940) Updates rubocop-rspec to 2.0.0 an bumps rubocop-discourse to 2.4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #938
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).