Fix InternalAffairs/ExampleDescription offenses on master
#1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 19, 2021
koic
reviewed
May 20, 2021
tejasbubane
force-pushed
the
fix-failing-rubocop
branch
from
9678924
to
6879ad6
Compare
pirj
approved these changes
May 20, 2021
tejasbubane
force-pushed
the
fix-failing-rubocop
branch
from
6879ad6
to
f7d1953
Compare
|
@pirj Fixed as per your review comments. |
pirj
reviewed
May 21, 2021
tejasbubane
force-pushed
the
fix-failing-rubocop
branch
from
f7d1953
to
7f11e75
Compare
|
Could you please add to the PR description a link to the change in rubocop/rubocop that prompted these changes? |
tejasbubane
force-pushed
the
fix-failing-rubocop
branch
from
7f11e75
to
dd40ff8
Compare
@bquorning Added |
|
Please ping us when your other PRs builds pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is failing with latest rubocop https://app.circleci.com/pipelines/github/rubocop/rubocop-rspec/887/workflows/cb3ac5d9-a753-42fd-a26d-86b9e5bd8c69/jobs/20828
Rubocop change: rubocop/rubocop#9797 - Released in rubocop
v1.15.0Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.Enabled: pendinginconfig/default.yml.VersionAddedindefault/config.ymlto the next minor version.If you have modified an existing cop's configuration options:
VersionChangedinconfig/default.ymlto the next major version.