Add ReceiveNever cop #628
Add ReceiveNever cop #628
Conversation
Darhazer
force-pushed
the
receive-never-cop
branch
from
1272f5e
to
ac87c1a
Compare
| lambda do |corrector| | ||
| corrector.replace(node.parent.loc.selector, 'not_to') | ||
| range = range_between( | ||
| node.loc.selector.begin_pos - 1, # match the dot as well |
There was a problem hiding this comment.
Just a thought: How does this work if the dot is the last character on the preceding line?
| (send #expectation? :to | ||
| { | ||
| $(send (send nil? :receive ...) :never) | ||
| $(send (send (send nil? :receive ...) ...) :never) |
There was a problem hiding this comment.
Why do we need two patterns here?
|
Btw, what do you think about putting together some RSpec Style Guide as a reference for the RSpec cops? It'd be nice if cops where linked to some document with the rationale behind them. |
|
|
||
| ### References | ||
|
|
||
| * [http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ReceiveNever](http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ReceiveNever) |
There was a problem hiding this comment.
This was originally intended to be used for links to blog posts and whatever, complementary to a standard "Style Guide" link.
There was a problem hiding this comment.
The rake tasks intercepts "StyleGuide" from the config, as we have full url there :/
Darhazer
force-pushed
the
receive-never-cop
branch
from
ac87c1a
to
d46358a
Compare
|
@bbatsov Good points both, but not specific to this PR. Would you mind opening two new issues where we can discuss them? |
Darhazer
force-pushed
the
receive-never-cop
branch
from
d46358a
to
446dd4a
Compare
| RUBY | ||
| end | ||
|
|
||
| it 'allows method callsed never' do |
|
|
||
| MSG = 'Use `not_to receive` instead of `never`.'.freeze | ||
|
|
||
| def_node_matcher :expectation?, Expectations::ALL.send_pattern |
There was a problem hiding this comment.
This matcher seems to not be used.
Darhazer
force-pushed
the
receive-never-cop
branch
from
446dd4a
to
8b7e180
Compare
Darhazer
force-pushed
the
receive-never-cop
branch
from
8b7e180
to
d9bbc0a
Compare
|
Updated |
Fixes #607
Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.