Add autocorrect for RSpec/ExpectActual #855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Jan 6, 2020
pirj
reviewed
Jan 7, 2020
| expectation = node.parent.parent | ||
| rhs = expectation.children.last | ||
| return unless rhs.is_a?(RuboCop::AST::MethodDispatchNode) | ||
| return if rhs.method_name != :eq |
There was a problem hiding this comment.
Maybe also :==, :eql?, :equal?, and :be?
A culprit with :be is that it might not have an argument:
expect(3).to beThere was a problem hiding this comment.
Hi @pirj, thanks for the suggestions. Could I trouble you to provide examples using the first three methods? I interpreted your suggestion as applying like so:
expect(123).to ==(bar)
expect(123).to eql?(bar)
expect(123).to equal?(bar)…but that doesn't appear to be valid:
Failure/Error: expect(123).to equal?(123)
ArgumentError:
The expect syntax does not support operator matchers, so you must pass a matcher to `#to`.
There was a problem hiding this comment.
My bad. Should of course be:
expect(123).to be
expect(123).to be == 123
expect(123).to eql(123)
expect(123).to equal(123)Thanks for the extra care.
|
Do you need a hand with this @dduugg ? Please let me know if you get stuck with something. |
|
Hi @pirj I'll close this until I have more bandwidth to cover the various examples. It seemed much simpler when I was able to autocorrect the cop's spec and my code with ease 😸 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an autocorrect to
RSpec/ExpectActual, swapping the arguments toexpectandeqwhen possible.Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).