Merge pull request #11659 from koic/fix_incorrect_autocorrect_for_lin…

…t_or_assignment_to_constant

Fix an incorrect autocorrect for `Lint/OrAssignmentToConstant`

changelog/fix_an_incorrect_autocorrect_for_lint_or_assignment_to_constant.md

@@ -0,0 +1 @@
+* [#11659](https://github.com/rubocop/rubocop/pull/11659): Fix an incorrect autocorrect for `Lint/OrAssignmentToConstant` when using or-assignment to a constant in method definition. ([@koic][])

lib/rubocop/cop/lint/or_assignment_to_constant.rb

@@ -31,6 +31,8 @@ def on_or_asgn(node)
           return unless lhs&.casgn_type?
 
           add_offense(node.loc.operator) do |corrector|
+            next if node.each_ancestor(:def, :defs).any?
+
             corrector.replace(node.loc.operator, '=')
           end
         end

spec/rubocop/cop/lint/or_assignment_to_constant_spec.rb

@@ -12,6 +12,43 @@
     RUBY
   end
 
+  it 'registers an offense with or-assignment to a constant in method definition' do
+    expect_offense(<<~RUBY)
+      def foo
+        M::CONST ||= 1
+                 ^^^ Avoid using or-assignment with constants.
+      end
+    RUBY
+
+    expect_no_corrections
+  end
+
+  it 'registers an offense with or-assignment to a constant in singleton method definition' do
+    expect_offense(<<~RUBY)
+      def self.foo
+        M::CONST ||= 1
+                 ^^^ Avoid using or-assignment with constants.
+      end
+    RUBY
+
+    expect_no_corrections
+  end
+
+  it 'registers an offense with or-assignment to a constant in method definition using `define_method`' do
+    expect_offense(<<~RUBY)
+      define_method :foo do
+        M::CONST ||= 1
+                 ^^^ Avoid using or-assignment with constants.
+      end
+    RUBY
+
+    expect_correction(<<~RUBY)
+      define_method :foo do
+        M::CONST = 1
+      end
+    RUBY
+  end
+
   it 'does not register an offense with plain assignment to a constant' do
     expect_no_offenses(<<~RUBY)
       CONST = 1