Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inheritance should work for all config options, not just Enabled. #4582

Closed
pyrogenic opened this issue Jul 7, 2017 · 0 comments
Closed

Inheritance should work for all config options, not just Enabled. #4582

pyrogenic opened this issue Jul 7, 2017 · 0 comments

Comments

@pyrogenic
Copy link

I would like to have our local dev environment mimic our build environment, in which lint failures fail the build. Unfortunately, it does not seem like I can raise the severity of all Lint cops at the same time.

I'm happy to work out the fix myself if such a PR would be accepted.

Expected behavior

Lint:
  Severity: error

Should change the severity for all Lint cops to error.

Actual behavior

Setting is silently ignored, while

Lint:
  Enabled: false

works as expected.

Steps to reproduce the problem

Add given configuration to rubocop.yml.

RuboCop version

$ bundle exec rubocop -v
0.47.1
jonas054 added a commit to jonas054/rubocop that referenced this issue Oct 1, 2017
@jonas054
[Fix rubocop#4582] Support department configuration of common params
b8c064a 
Severity is the most obvious candidate for department-wide
setting, but the solution is general. A cop's individual setting
overrides the parameter from its department.
@bbatsov bbatsov closed this as completed in e50f5be Oct 1, 2017
@mpotter mpotter mentioned this issue Oct 21, 2017
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pyrogenic