Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive and a true negative for Style/FetchEnvVar #10565

Merged
merged 1 commit into from
Apr 23, 2022

Commits on Apr 23, 2022

  1. Fix a false positive and a true negative for Style/FetchEnvVar

    This PR improves the edge case of `Style/FetchEnvVar`.
    There are cases that are false positive
    and true negative, and it eliminates them.
    
    false positive cases are as follows:
    ```ruby
    ENV['X'] &&= y
    ```
    
    true negative cases are as follows:
    ```ruby
    y ||= ENV['X']
    y &&= ENV['X']
    ```
    
    This PR follows up on the same issue
    as the Issue raised at rubocop#10557.
    ydah committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    d8f3c8f View commit details
    Browse the repository at this point in the history