[Fix #11517] Make Lint/Debugger aware of some debug methods
#11518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#11517. This PR makes `Lint/Debugger` aware of `p`, `PP.pp`, and `pp` methods. These are used for debugging purposes basically. OTOH, `puts` is not included in the config because it is used for the intended standard output.
|
Looks good to me. Thanks! |
Merged
7 tasks
|
What to you think about excluding spec files by default for this cop? I agree that it should be not present in library/applicatoin itself, but not sure that some additional print statements in spec files are really bad |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Feb 10, 2023
This PR rolls back the print debug default configuration (rubocop#11518) of `Lint/Debugger` based on the following feedback. - rubocop#11557 (comment) - rubocop#11552 (comment) - rubocop#11518 (comment) It seems like it was a bad idea to mix debugger and print debug methods by default. This PR updates `Lint/Debugger` cop defaults to handle only debugger methods as per the cop name. OTOH, it leaves the logic in rubocop#11557 to prevent false positives when user configures print debug methods. e.g. rubocop#11517 (comment)
8 tasks
|
I reconsidered based on some feedback and opened #11564. Thank you. |
bbatsov
pushed a commit
that referenced
this pull request
Feb 11, 2023
This PR rolls back the print debug default configuration (#11518) of `Lint/Debugger` based on the following feedback. - #11557 (comment) - #11552 (comment) - #11518 (comment) It seems like it was a bad idea to mix debugger and print debug methods by default. This PR updates `Lint/Debugger` cop defaults to handle only debugger methods as per the cop name. OTOH, it leaves the logic in #11557 to prevent false positives when user configures print debug methods. e.g. #11517 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11517.
This PR makes
Lint/Debuggeraware ofp,PP.pp, andppmethods. These are used for debugging purposes basically. OTOH,putsis not included in the config because it is used for the intended standard output.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.