[Fix #11556] Fix a false positive for Lint/Debugger
#11557
Conversation
koic
force-pushed
the
fix_a_false_positive_for_lint_debugger
branch
from
8c5d0a0
to
8cf787d
Compare
|
Looks okay, sans the CI failures. I'm starting to wonder, though, if it was a good idea to mix the debug methods that actually start some debugger (and don't take arguments) with print debugging methods (which take some arguments), as for them we could just check if they are invoked without any arguments. Anyways, the fix will do for now. |
Fixes rubocop#11556. This PR fixes a false positive for `Lint/Debugger` when `p` is an argument of method call. Basically, debugger methods are not used as a method argument without arguments.
koic
force-pushed
the
fix_a_false_positive_for_lint_debugger
branch
from
8cf787d
to
bf0f8a4
Compare
Ah, it may have been better to distinguish between them. For now, I'd like to look feedback after #11556 issue is resolved. |
This PR rolls back the print debug default configuration (rubocop#11518) of `Lint/Debugger` based on the following feedback. - rubocop#11557 (comment) - rubocop#11552 (comment) - rubocop#11518 (comment) It seems like it was a bad idea to mix debugger and print debug methods by default. This PR updates `Lint/Debugger` cop defaults to handle only debugger methods as per the cop name. OTOH, it leaves the logic in rubocop#11557 to prevent false positives when user configures print debug methods. e.g. rubocop#11517 (comment)
This PR rolls back the print debug default configuration (#11518) of `Lint/Debugger` based on the following feedback. - #11557 (comment) - #11552 (comment) - #11518 (comment) It seems like it was a bad idea to mix debugger and print debug methods by default. This PR updates `Lint/Debugger` cop defaults to handle only debugger methods as per the cop name. OTOH, it leaves the logic in #11557 to prevent false positives when user configures print debug methods. e.g. #11517 (comment)
|
|
Fixes #11556.
This PR fixes a false positive for
Lint/Debuggerwhenpis an argument of method call. Basically, debugger methods are not used as a method argument without arguments.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.