[Fix #12087] Fix a false positive for Style/ArgumentsForwarding
#12101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#12087, rubocop#12089, rubocop#12096, and rubocop#12100. This PR fixes false positives for `Style/ArgumentsForwarding` when leading argument with rest arguments.
koic
force-pushed
the
fix_false_positives_for_style_arguments_forwarding
branch
from
42554d7
to
91c35af
Compare
|
//cc @owst |
|
Thanks for fixing these issues @koic - I did try to indicate that I've been working (albeit a bit slowly, apologies!) on a fix for these same issues that I think is slightly cleaner by also refactoring some of my original code from #11794 I'll pull it together and open a PR this morning, and we can compare? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12087, #12089, #12096, and #12100.
This PR fixes false positives for
Style/ArgumentsForwardingwhen leading argument with rest arguments.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.