Add new Lint/ItWithoutArgumentsInBlock cop
#12518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_new_lint_it_without_arguments_in_block_cop
branch
2 times, most recently
from
87e6dce
to
d3d0c0f
Compare
Follow up https://bugs.ruby-lang.org/issues/18980 and ruby/ruby#9152. Emulates the following Ruby warnings in Ruby 3.3. ```ruby $ ruby -e '0.times { it }' -e:1: warning: `it` calls without arguments will refer to the first block param in Ruby 3.4; use it() or self.it ``` `it` calls without arguments will refer to the first block param in Ruby 3.4. So use `it()` or `self.it` to ensure compatibility. ```ruby # bad do_something { it } # good do_something { it() } do_something { self.it } ```
koic
force-pushed
the
add_new_lint_it_without_arguments_in_block_cop
branch
from
d3d0c0f
to
4c1884b
Compare
8 tasks
8 tasks
|
Looks good! |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 11, 2023
This PR makes `Style/RedundantSelf` allow the `self.it` method in a block.
It respects following Ruby 3.3's warning:
```console
$ ruby -e '0.times { begin; it; end }'
-e:1: warning: `it` calls without arguments will refer to the first block param in Ruby 3.4; use it() or self.it
```
Related PR ... rubocop#12518
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 11, 2023
This PR makes `Style/MethodCallWithoutArgsParentheses` allow the parenthesized `it` method in a block.
It respects following Ruby 3.3's warning:
```console
$ ruby -e '0.times { begin; it; end }'
-e:1: warning: `it` calls without arguments will refer to the first block param in Ruby 3.4; use it() or self.it
```
Related PR ... rubocop#12518
bbatsov
pushed a commit
that referenced
this pull request
Dec 11, 2023
This PR makes `Style/RedundantSelf` allow the `self.it` method in a block.
It respects following Ruby 3.3's warning:
```console
$ ruby -e '0.times { begin; it; end }'
-e:1: warning: `it` calls without arguments will refer to the first block param in Ruby 3.4; use it() or self.it
```
Related PR ... #12518
bbatsov
pushed a commit
that referenced
this pull request
Dec 11, 2023
This PR makes `Style/MethodCallWithoutArgsParentheses` allow the parenthesized `it` method in a block.
It respects following Ruby 3.3's warning:
```console
$ ruby -e '0.times { begin; it; end }'
-e:1: warning: `it` calls without arguments will refer to the first block param in Ruby 3.4; use it() or self.it
```
Related PR ... #12518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up https://bugs.ruby-lang.org/issues/18980 and ruby/ruby#9152.
Emulates the following Ruby warnings in Ruby 3.3.
itcalls without arguments will refer to the first block param in Ruby 3.4.So use
it()orself.itto ensure compatibility.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.