Make Style/MethodCallWithoutArgsParentheses allow parenthesized it
#12522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
make_style_method_call_without_args_parentheses_respect_ruby33_warn
branch
2 times, most recently
from
ad3017b
to
646d68f
Compare
|
I think this should be mentioned in the cop's examples. |
koic
force-pushed
the
make_style_method_call_without_args_parentheses_respect_ruby33_warn
branch
from
646d68f
to
d343392
Compare
This PR makes `Style/MethodCallWithoutArgsParentheses` allow the parenthesized `it` method in a block.
It respects following Ruby 3.3's warning:
```console
$ ruby -e '0.times { begin; it; end }'
-e:1: warning: `it` calls without arguments will refer to the first block param in Ruby 3.4; use it() or self.it
```
Related PR ... rubocop#12518
koic
force-pushed
the
make_style_method_call_without_args_parentheses_respect_ruby33_warn
branch
from
d343392
to
21c21c8
Compare
|
Sure, I've updated the cop's documentation. |
|
Thanks! |
koic
deleted the
make_style_method_call_without_args_parentheses_respect_ruby33_warn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Style/MethodCallWithoutArgsParenthesesallow the parenthesizeditmethod in a block.It respects following Ruby 3.3's warning:
Related PR ... #12518
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.