Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of textDocument/diagnostic #12664

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix handling of textDocument/diagnostic #12664

merged 1 commit into from
Apr 24, 2024

Commits on Feb 2, 2024

  1. Fix handling of textDocument/diagnostic

    The `textDocument` parameter for the `textDocument/diagnostic` request
    is of type `TextDocumentIdentifier`, which has a single property `uri`
    of type `DocumentUri`.
    
    Ref: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_diagnostic
    
    According to the spec the `DocumentUri` type does not hold the contents
    of the document, which the handler currently relies on in order to
    publish diagnostics to the client.
    
    This breaks the LSP mode in Neovim 0.10, which now supports pull
    diagnostics, and possibly other editors too. The same problem exists in
    `standardrb` (standardrb/standard#575)
    
    I have made the `textDocument/diagnostic` hander a no-op, since
    diagnostics are already being pushed to clients on
    `textDocument/didChange`.
    muxcmux committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    48b8620 View commit details
    Browse the repository at this point in the history