Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xmlschema to accepted Rails/TimeZone methods. #5899

Merged

Conversation

koic
Copy link
Member

@koic koic commented May 20, 2018

Follow up of #5761 and #1787.

iso8601 and rfc3339 methods are aliases of xmlschema.
https://github.com/rails/rails/blob/v5.2.0/activesupport/lib/active_support/time_with_zone.rb#L145-L153

If this cop accepts these methods, this cop need to also accept the original xmlschema.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

Follow up of rubocop#5761 and rubocop#1787.

`iso8601` and `rfc3339` methods are aliases of `xmlschema`.
https://github.com/rails/rails/blob/v5.2.0/activesupport/lib/active_support/time_with_zone.rb#L145-L153

If this cop accepts these methods, this cop need to also
accept the original `xmlschema`.
@bbatsov bbatsov merged commit 1ea03ac into rubocop:master May 20, 2018
@koic koic deleted the add_acceptable_method_to_rails_time_zone branch May 20, 2018 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants