Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RuboCop RSpec todos #9005

Merged
merged 2 commits into from
Nov 7, 2020
Merged

Conversation

bquorning
Copy link
Contributor

@bquorning bquorning commented Nov 7, 2020

Fix a few minor issues that were overlooked in #9002.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • [-] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@mergify mergify bot merged commit 37467bc into rubocop:master Nov 7, 2020
@marcandre
Copy link
Contributor

Cool, thanks!

@bquorning bquorning deleted the fix-rubocop-rspec-todos branch November 8, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants