Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RuboCop RSpec todos #9005

Merged
merged 2 commits into from
Nov 7, 2020
Merged

Fix RuboCop RSpec todos #9005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3303b3
Remove exemptions for fixed cop
bquorning Nov 7, 2020
175344d
Re-enable spec after rubocop-rspec 2.0
bquorning Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,6 @@ RSpec/NestedGroups:
RSpec/MultipleMemoizedHelpers:
Enabled: false

# Buggy cop
# See https://github.com/rubocop-hq/rubocop-rspec/pull/1018
RSpec/EmptyExampleGroup:
Exclude:
- 'spec/rubocop/cli/cli_options_spec.rb'
- 'spec/rubocop/cop/lint/script_permission_spec.rb'
- 'spec/rubocop/cop/style/empty_else_spec.rb'
- 'spec/rubocop/result_cache_spec.rb'

Performance/CollectionLiteralInLoop:
Exclude:
- 'Rakefile'
Expand Down
3 changes: 1 addition & 2 deletions spec/rubocop/cop/generator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,7 @@ def on_send(node)
expect(runner.run([])).to be true
end

# TODO: include it back after rubocop-rspec updated to support deep departments names
xit 'generates a spec file that has no offense' do
it 'generates a spec file that has no offense' do
generator.write_spec
expect(runner.run([])).to be true
end
Expand Down