Allow parentheses in operator method calls for Style/MethodCallWithArgsParentheses

changelog/fix_allow_parentheses_in_operator_methods_calls_for_style_method_call_with_args_parentheses.md

@@ -0,0 +1 @@
+* [#9620](https://github.com/rubocop/rubocop/pull/9620): Allow parentheses in operator methods calls for `Style/MethodCallWithArgsParentheses` `EnforcedStyle: omit_parentheses`. ([@gsamokovarov][])

lib/rubocop/cop/style/method_call_with_args_parentheses.rb

@@ -79,6 +79,30 @@ module Style
       #   # good
       #   foo.enforce strict: true
       #
+      #   # good
+      #   # Allows parens for calls that won't produce valid Ruby or be ambiguous.
+      #   model.validate strict(true)
+      #
+      #   # good
+      #   # Allows parens for calls that won't produce valid Ruby or be ambiguous.
+      #   yield path, File.basename(path)
+      #
+      #   # good
+      #   # Operators methods calls with parens
+      #   array&.[](index)
+      #
+      #   # good
+      #   # Operators methods without parens, if you prefer
+      #   array.[] index
+      #
+      #   # good
+      #   # Operators methods calls with parens
+      #   array&.[](index)
+      #
+      #   # good
+      #   # Operators methods without parens, if you prefer
+      #   array.[] index
+      #
       # @example IgnoreMacros: true (default)
       #
       #   # good

lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb

@@ -5,6 +5,7 @@ module Cop
     module Style
       class MethodCallWithArgsParentheses
         # Style omit_parentheses
+        # rubocop:disable Metrics/ModuleLength
         module OmitParentheses
           TRAILING_WHITESPACE_REGEX = /\s+\Z/.freeze
           OMIT_MSG = 'Omit parentheses for method calls with arguments.'
@@ -15,7 +16,7 @@ module OmitParentheses
           def omit_parentheses(node)
             return unless node.parenthesized?
             return if inside_endless_method_def?(node)
-            return if node.implicit_call?
+            return if syntax_like_method_call?(node)
             return if super_call_without_arguments?(node)
             return if allowed_camel_case_method_call?(node)
             return if legitimate_call_with_parentheses?(node)
@@ -43,6 +44,10 @@ def inside_endless_method_def?(node)
             node.each_ancestor(:def).any?(&:endless?) && node.arguments.any?
           end
 
+          def syntax_like_method_call?(node)
+            node.implicit_call? || node.operator_method?
+          end
+
           def super_call_without_arguments?(node)
             node.super_type? && node.arguments.none?
           end
@@ -173,6 +178,7 @@ def assigned_before?(node, target)
               node.loc.operator.begin < target.loc.begin
           end
         end
+        # rubocop:enable Metrics/ModuleLength
       end
     end
   end

spec/rubocop/cop/style/method_call_with_args_parentheses_spec.rb

@@ -753,6 +753,16 @@ def seatle_style arg: default(42)
       expect_no_offenses('Something.find(criteria: given)&.field')
     end
 
+    it 'accepts parens in operator method calls' do
+      expect_no_offenses(<<~RUBY)
+        data.[](value)
+        data&.[](value)
+        string.<<(even_more_string)
+        ruby.==(good)
+        ruby&.===(better)
+      RUBY
+    end
+
     context 'allowing parenthesis in chaining' do
       let(:cop_config) do
         {