Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加travis-ci集成测试功能,请参考我的commit #7

Closed
xiaods opened this issue Apr 4, 2012 · 3 comments
Closed

增加travis-ci集成测试功能,请参考我的commit #7

xiaods opened this issue Apr 4, 2012 · 3 comments

Comments

@xiaods
Copy link
Contributor

xiaods commented Apr 4, 2012

只要ruby-china账号加上travis-ci的key。在加一个.travis.yml就可以了。

xiaods@610531b

效果请看:
https://github.com/xiaods/ruby-china

目前有一个exceptional error. 我建议@huacnlee在review一下。

Failures:

243

244 1) TopicsHelper format_topic_body should right with Chinese neer URL

245 Failure/Error: '<p>此版本并非线上的http://yavaeye.com的源码.</p>'

246 expected: "<p>此版本并非线上的http://yavaeye.com的源码.</p>"

247 got: "<p>此版本并非线上的<a href=\"http://yavaeye.com\" rel=\"nofollow\" target=\"_blank\">http://yavaeye.com</a>的源码.</p>" (using ==)

248 # ./spec/helpers/topics_helper_spec.rb:10:in `block (3 levels) in <top (required)>'

249

250Finished in 35.6 seconds

251294 examples, 1 failure

252

253Failed examples:

254

255rspec ./spec/helpers/topics_helper_spec.rb:6 # TopicsHelper format_topic_body should right with Chinese neer URL

256rake aborted!

TODO: 这行是由于 Redcarpet 的 auto_link 方法转换连起来的会有编码错误

  #  @huacnlee提醒说在某些环境下面,下面测试会Pass。所以有可能在你的测试环境会失败。
  helper.format_topic_body("此版本并非线上的http://yavaeye.com的源码.").should ==
    '<p>此版本并非线上的http://yavaeye.com的源码.</p>'

这个断言上面提醒会auto_link,但expected中确给出不加link的result.我怎么感觉意思不同阿。
这里我们到底想让带连接的一句话返回原文,还是加上链接返回句子

@huacnlee
Copy link
Member

huacnlee commented Apr 5, 2012

Pull request 呀

@xiaods
Copy link
Contributor Author

xiaods commented Apr 5, 2012

还需要你动手到travis-ci去绑ruby-china的github账号,我为了给你看效果,用的自己的账号。

@xiaods
Copy link
Contributor Author

xiaods commented Apr 5, 2012

已经出来了。关了。

@xiaods xiaods closed this as completed Apr 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants