Implemented synchronized PriorityQueue. #398
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original priority queue implementation was added as an internal implementation detail of
TimerSet
. It was not thread-safe because TimerSet handled the synchronization. I recently began experimenting with a Rails ActiveJob adapter built on concurrent-ruby. I began thinking about adding prioritization to the adapter and realized that I might be able to use our priority queue, so I took a stab at creating a thread-safe wrapper around our current implementation.This is a low-priority item since it doesn't look like my Rails PR is going to be merged. But this update may still be a nice addition to our gem.
This PR does a few things:
Concurrent::PriorityQueue
which leveragesConcurrent::Synchronization::Object
.Concurrent::PriorityQueue
.