Fixing CI

Gemfile

@@ -6,13 +6,14 @@ gem 'concurrent-ruby-ext', path: '.', platform: :mri
 
 group :development do
   gem 'rake', '~> 11.0'
-  gem 'rake-compiler', '~> 0.9.5'
-  gem 'rake-compiler-dock', '~> 0.4.3'
+  gem 'rake-compiler', '~> 1.0.0'
+  gem 'rake-compiler-dock', '~> 0.6.0'
   gem 'gem-compiler', '~> 0.3.0'
   gem 'benchmark-ips', '~> 2.7'
 
   # documentation
   gem 'countloc', '~> 0.4.0', :platforms => :mri, :require => false
+  # TODO (pitr-ch 04-May-2018): update to remove: [DEPRECATION] `last_comment` is deprecated.  Please use `last_description` instead.
   gem 'yard', '~> 0.8.0', :require => false
   gem 'redcarpet', '~> 3.3', platforms: :mri # understands github markdown
   gem 'md-ruby-eval'

Rakefile

@@ -181,9 +181,7 @@ begin
                 --backtrace
                 --seed 1
                 --format documentation
-                --tag ~unfinished
-                --tag ~notravis
-                --tag ~buggy ]
+                --tag ~notravis ]
 
   RSpec::Core::RakeTask.new(:travis) do |t|
     t.rspec_opts = ['--color', *options].join(' ')

ext/ConcurrentRubyExtService.java

@@ -2,7 +2,6 @@
 
 import org.jruby.Ruby;
 import org.jruby.runtime.load.BasicLibraryService;
-import com.concurrent_ruby.ext.JRubyMapBackendLibrary;
 
 public class ConcurrentRubyExtService implements BasicLibraryService {
     public boolean basicLoad(final Ruby runtime) throws IOException {

lib/concurrent/actor.rb

@@ -35,9 +35,13 @@ def self.current
     end
 
     @root = Concurrent::Promises.delay do
-      Core.new(parent: nil, name: '/', class: Root, initialized: future = Concurrent::Promises.resolvable_future).reference.tap do
-        future.wait!
-      end
+      Core.
+        new(parent:      nil,
+            name:        '/',
+            class:       Root,
+            initialized: future = Concurrent::Promises.resolvable_future).
+        reference.
+        tap { future.wait! }
     end
 
     # A root actor, a default parent of all actors spawned outside an actor

lib/concurrent/actor/core.rb

@@ -90,8 +90,9 @@ def remove_child(child)
       # can be called from other alternative Reference implementations
       # @param [Envelope] envelope
       def on_envelope(envelope)
+        log(DEBUG) { "is  #{envelope.future ? 'asked' : 'told'} #{envelope.message.inspect} by #{envelope.sender}" }
         schedule_execution do
-          log(DEBUG) { "was #{envelope.future ? 'asked' : 'told'} #{envelope.message.inspect} by #{envelope.sender}" }
+          log(DEBUG) { "was #{envelope.future ? 'asked' : 'told'} #{envelope.message.inspect} by #{envelope.sender} - processing" }
           process_envelope envelope
         end
         nil

lib/concurrent/atomic/count_down_latch.rb

@@ -55,7 +55,7 @@ module Concurrent
   # @!macro internal_implementation_note
   CountDownLatchImplementation = case
                                  when Concurrent.on_jruby?
-                                   JavaCountDownLatch
+                                   MutexCountDownLatch
                                  else
                                    MutexCountDownLatch
                                  end

lib/concurrent/concern/logging.rb

@@ -17,7 +17,12 @@ module Logging
       def log(level, progname, message = nil, &block)
         #NOTE: Cannot require 'concurrent/configuration' above due to circular references.
         #      Assume that the gem has been initialized if we've gotten this far.
-        (@logger || Concurrent.global_logger).call level, progname, message, &block
+        logger = if defined?(@logger) && @logger
+                   @logger
+                 else
+                   Concurrent.global_logger
+                 end
+        logger.call level, progname, message, &block
       rescue => error
         $stderr.puts "`Concurrent.configuration.logger` failed to log #{[level, progname, message, block]}\n" +
           "#{error.message} (#{error.class})\n#{error.backtrace.join "\n"}"

lib/concurrent/exchanger.rb

@@ -329,7 +329,7 @@ def do_exchange(value, timeout)
   # @!macro internal_implementation_note
   ExchangerImplementation = case
                             when Concurrent.on_jruby?
-                              JavaExchanger
+                              RubyExchanger
                             else
                               RubyExchanger
                             end

lib/concurrent/ivar.rb

@@ -157,9 +157,8 @@ def ns_initialize(value, opts)
       self.observers = Collection::CopyOnWriteObserverSet.new
       set_deref_options(opts)
 
-      if value == NULL
-        @state = :pending
-      else
+      @state = :pending
+      if value != NULL
         ns_complete_without_notification(true, value, nil)
       end
     end

lib/concurrent/synchronization/abstract_struct.rb

@@ -138,13 +138,15 @@ def ns_initialize(*values)
         end
         unless name.nil?
           begin
+            parent.send :remove_const, name if parent.const_defined? name
             parent.const_set(name, clazz)
-            parent.const_get(name)
+            clazz
           rescue NameError
             raise NameError.new("identifier #{name} needs to be constant")
           end
         end
         members.each_with_index do |member, index|
+          clazz.send :remove_method, member if clazz.method_defined? member
           clazz.send(:define_method, member) do
             @values[index]
           end

lib/concurrent/timer_task.rb

@@ -189,6 +189,7 @@ class TimerTask < RubyExecutorService
     def initialize(opts = {}, &task)
       raise ArgumentError.new('no block given') unless block_given?
       super
+      set_deref_options opts
     end
 
     # Is the executor running?

spec/concurrent/actor_spec.rb

@@ -6,7 +6,7 @@ module Actor
 
     # FIXME better tests!
 
-    RSpec.describe 'Concurrent::Actor', edge: true, if: !defined?(JRUBY_VERSION) do
+    RSpec.describe 'Concurrent::Actor', edge: true do
 
       def terminate_actors(*actors)
         actors.each do |actor|
@@ -148,7 +148,7 @@ def on_message(message)
           end
         end
 
-        it 'terminates with all its children', buggy: true do
+        it 'terminates with all its children', notravis: true do
           child = subject.ask! :child
           expect(subject.ask!(:terminated?)).to be_falsey
           subject.ask(:terminate!).wait
@@ -172,7 +172,7 @@ def on_message(message)
       describe 'message redirecting' do
         let(:parent) do
           AdHoc.spawn!(:parent) do
-            child = AdHoc.spawn!(:child) { -> m { m+1 } }
+            child = AdHoc.spawn!(:child) { -> m { m + 1 } }
             -> message do
               if message == :child
                 child
@@ -287,7 +287,7 @@ def on_message(message)
           test = AdHoc.spawn! name: :tester, behaviour_definition: resuming_behaviour do
 
             actor = AdHoc.spawn! name:                 :pausing,
-                                behaviour_definition: Behaviour.restarting_behaviour_definition do
+                                 behaviour_definition: Behaviour.restarting_behaviour_definition do
               queue << :init
               -> m { m == :add ? 1 : pass }
             end
@@ -313,7 +313,7 @@ def on_message(message)
       end
 
       describe 'pool' do
-        it 'supports asks', buggy: true do
+        it 'supports asks', notravis: true do
           children = Queue.new
           pool     = Concurrent::Actor::Utils::Pool.spawn! 'pool', 5 do |index|
             worker = Concurrent::Actor::Utils::AdHoc.spawn! name: "worker-#{index}", supervised: true do