Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing CI #700

Merged
merged 27 commits into from May 23, 2018
Merged

Fixing CI #700

merged 27 commits into from May 23, 2018

Conversation

pitr-ch
Copy link
Member

@pitr-ch pitr-ch commented Feb 25, 2018

fix #681

@ghost ghost assigned pitr-ch Feb 25, 2018
@ghost ghost added the in progress label Feb 25, 2018
@pitr-ch pitr-ch force-pushed the pitr-ch/ci branch 2 times, most recently from 626e7a9 to d3d9f6d Compare March 2, 2018 17:05
@pitr-ch pitr-ch changed the title Do not use global pool in actor tests Fixing CI Mar 2, 2018
@pitr-ch pitr-ch force-pushed the pitr-ch/ci branch 3 times, most recently from c239a4f to da7e1b2 Compare March 4, 2018 19:30
@pitr-ch pitr-ch force-pushed the pitr-ch/ci branch 2 times, most recently from 230416b to 2be0f3c Compare May 7, 2018 08:55
pitr-ch added 20 commits May 10, 2018 10:48
@pitr-ch
Remove actor test exclusion on JRuby
e469e6b
@pitr-ch
Scope THREADS constant
cb1a0a6
@pitr-ch
Require support files directly
e276148
@pitr-ch
Remove trailing spaces
0ac25cb
@pitr-ch
Do not reset global threads
82cae34
@pitr-ch
Fix uninitialized instance variable warning
4e63aec
@pitr-ch
Update build tools
151c4b0
@pitr-ch
Remove redundant import
744ded7
@pitr-ch
Log when message arrives and when it's processed by actor
c4fb0bd
@pitr-ch
Formatting
8ec8a32
@pitr-ch
Ensure all threads in tests terminate
c8564b6
@pitr-ch
Fix some warnings during rspec tests
261832d
@pitr-ch
rename to avoid IDE confusion
401b3de
@pitr-ch
Unify rspec tags
366d6aa
@pitr-ch
remove trailing spaces
8614384
@pitr-ch
Rollback using Java Exchanger and CountDownLatch implementations
1e51d2c
@pitr-ch
make sure sentinel values are ::Objects
23cb3f9
@pitr-ch
Rollback java executor implementation
a6fc08f
@pitr-ch
Reduce output pollution by warnings
e14ccb3
@pitr-ch
Do not call subject/let defined methods in after block when the threa…
ab5cdf2 
…ds are reaped
@pitr-ch pitr-ch force-pushed the pitr-ch/ci branch 13 times, most recently from 454dbda to 1cd0c0e Compare May 22, 2018 07:45
@pitr-ch pitr-ch merged commit eca4cc0 into master May 23, 2018
@ghost ghost removed the in progress label May 23, 2018
@pitr-ch pitr-ch deleted the pitr-ch/ci branch May 23, 2018 16:14
kares
kares reviewed May 24, 2018
View reviewed changes
lib/concurrent/atomic/count_down_latch.rb
@@ -55,7 +55,7 @@ module Concurrent
# @!macro internal_implementation_note
CountDownLatchImplementation = case
when Concurrent.on_jruby?
JavaCountDownLatch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, could we get some details on why the 'native' JRuby stuff, seems to be going away?
understand the limited time for maintenance but still seems weird these had to go ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, please have a look at #717. I am updating the changelog before release, and when the 1.0.6.pre goes out it will mention this as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ask any follow up questions there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kares kares kares left review comments

Assignees

@pitr-ch pitr-ch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Travis tests are failing on JRuby
2 participants
@pitr-ch @kares