-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Rename the current help
command so it can be used to display command documentation
#450
Comments
While the two of us are allowed to add/modify IRB commands by just reviewing each other's PR, renaming/replacing an existing command would probably not be considered the same kind of change. It'd be nice to file a ticket on Redmine if you want to land this feature as |
I see. I'll first add something like |
I think there was a moment when starting irb CLI was very slow, which could be related to it. We even have a benchmark for it under ruby/ruby/benchmark (irb_exec or something like that), so you may try it with and without lazy load. Though, I don't get why you can't maintain lazy load. You'd only need to lazily load everything when you need to show/generate docs. |
Because I didn't think about that 😅 Thanks for the idea 👍 |
I'm closing this for now as we already implemented the main functionality of this command. I'll open a separate issue for repurposing the |
This proposal includes 3 changes:
Add documentation API to command classes. For example, if we want to have pry-style APIs:
Rename the current
help
command (showing API documents) to something else, likedoc
pry
,byebug
anddebug
, thehelp
command are all used for showing command documents. So I think it's better to align with them.Support the new
help
command to list command documents:help
- list all available commandspry
orbyebug
do, we only display commands' descriptions.debug
, we'll display full documentation for all commands. So in this case we won't need thedescription
attribute.help <cmd>
- display individual commands' full usage (banner).Since this will be a breaking change (renaming a command), we'll need to bump the version that includes this feature to
2.0
.The text was updated successfully, but these errors were encountered: