Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is broken on ruby-head #23

Closed
eregon opened this issue Jan 11, 2024 · 1 comment
Closed

CI is broken on ruby-head #23

eregon opened this issue Jan 11, 2024 · 1 comment

Comments

@eregon
Copy link
Member

eregon commented Jan 11, 2024

See https://github.com/ruby/pp/actions/runs/7489634039/job/20386628987

 ===============================================================================
Failure: test_lasgn_literal(PPTestModule::PPAbstractSyntaxTree)
/home/runner/work/pp/pp/test/test_pp.rb:235:in `test_lasgn_literal'
     232:     def test_lasgn_literal
     233:       ast = AST.parse("_=1")
     234:       expected = "(SCOPE@1:0-1:3 tbl: [:_] args: nil body: (LASGN@1:0-1:3 :_ (LIT@1:2-1:3 1)))"
  => 235:       assert_equal(expected, PP.singleline_pp(ast, ''.dup), ast)
     236:     end
     237:   end
     238: end
#<RubyVM::AbstractSyntaxTree::Node:0x00007f8b9029b4e0>
<"(SCOPE@1:0-1:3 tbl: [:_] args: nil body: (LASGN@1:0-1:3 :_ (LIT@1:2-1:3 1)))"> expected but was
<"(SCOPE@1:0-1:3 tbl: [:_] args: nil body: (LASGN@1:0-1:3 :_ (INTEGER@1:2-1:3 1)))">

diff:
? (SCOPE@1:0-1:3 tbl: [:_] args: nil body: (LASGN@1:0-1:3 :_ (LINTEGER@1:2-1:3 1)))
===============================================================================

Probably not ideal to depend on unstable/experimental RubyVM::AbstractSyntaxTree in pp's CI.

@hsbt
Copy link
Member

hsbt commented Sep 11, 2024

The current HEAD is working fine.

@hsbt hsbt closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants