Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION] FileList['[A-Z]*'] matches files starting with lower case character on default OS X file system using Ruby 2.2 #32

Closed
donv opened this issue Feb 28, 2015 · 3 comments

Comments

@donv
Copy link
Contributor

donv commented Feb 28, 2015

The default OS X file system is case-aware, and casing used to be respected in FileList.

Including only files starting with an upper case character in gems is a very common use case which should have continued support by Rake.

  spec.files = FileList['[A-Z]*', 'bin/*', 'lib/**/*', 'test/**/*'].to_a
@drbrain
Copy link
Member

drbrain commented Feb 28, 2015

Rake uses glob and has for years (see @698a54980ef0e7f84447ee67f865366f56f2857a) so I think this comes from the glob changes in Ruby 2.2 since I don't see or remember rake changes to FileList resolution.

To check, does latest rake behave the same on Ruby 2.1? This way we can determine where the regression lies.

(See the ruby 2.2 ChangeLog for the glob changes on case insensitive filesystems)

@donv
Copy link
Contributor Author

donv commented Mar 3, 2015

Yes, it is the change in Ruby 2.2 that does the change in FileList. Should this behavior bleed through?

Is there a way to get the old behavior back with FileList, or do we have to resort to

  spec.files = FileList['[A-Z]*'].select{|f| f =~ /^[A-Z]/} + FileList['bin/*', 'lib/**/*', 'test/**/*'].to_a

@hsbt
Copy link
Member

hsbt commented Jan 20, 2023

It seems not Rake issue.

@hsbt hsbt closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants