Skip to content

Commit

Permalink
[ruby/ostruct] method_missing is private
Browse files Browse the repository at this point in the history
  • Loading branch information
marcandre committed Sep 14, 2020
1 parent 606c009 commit 125605a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 27 deletions.
2 changes: 1 addition & 1 deletion lib/ostruct.rb
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def freeze
super
end

def method_missing(mid, *args) # :nodoc:
private def method_missing(mid, *args) # :nodoc:
len = args.length
if mname = mid[/.*(?==\z)/m]
if len != 1
Expand Down
29 changes: 3 additions & 26 deletions spec/ruby/library/openstruct/method_missing_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,43 +7,20 @@
end

it "raises an ArgumentError when not passed any additional arguments" do
-> { @os.method_missing(:test=) }.should raise_error(ArgumentError)
end

it "raises a TypeError when self is frozen" do
@os.freeze
-> { @os.method_missing(:test=, "test") }.should raise_error(RuntimeError)
end

it "creates accessor methods" do
@os.method_missing(:test=, "test")
@os.respond_to?(:test=).should be_true
@os.respond_to?(:test).should be_true

@os.test.should == "test"
@os.test = "changed"
@os.test.should == "changed"
-> { @os.send(:test=) }.should raise_error(ArgumentError)
end
end

describe "OpenStruct#method_missing when passed additional arguments" do
it "raises a NoMethodError when the key does not exist" do
os = OpenStruct.new
-> { os.method_missing(:test, 1, 2, 3) }.should raise_error(NoMethodError)
-> { os.test(1, 2, 3) }.should raise_error(NoMethodError)
end

ruby_version_is "2.7" do
it "raises an ArgumentError when the key exists" do
os = OpenStruct.new(test: 20)
-> { os.method_missing(:test, 1, 2, 3) }.should raise_error(ArgumentError)
-> { os.test(1, 2, 3) }.should raise_error(ArgumentError)
end
end
end

describe "OpenStruct#method_missing when not passed any additional arguments" do
it "returns the value for the passed method from the method/value table" do
os = OpenStruct.new(age: 20)
os.method_missing(:age).should eql(20)
os.method_missing(:name).should be_nil
end
end

0 comments on commit 125605a

Please sign in to comment.