Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ruby objects from numeric node comparison #10079

Closed
wants to merge 1 commit into from
Closed

Remove ruby objects from numeric node comparison #10079

wants to merge 1 commit into from

Commits on Feb 23, 2024

  1. Remove ruby objects from numeric node comparison 

    Parser needs to compare nodes to warn duplicate keys in a hash,
for example:

```
{1 => :a, 1 => :b}
# => test.rb:1: warning: key 1 is duplicated and overwritten on line 1
```

This commit stop using ruby objects for hash value calculation and
node comparison.
Bignum is needed when comparing different radix numeric nodes.
    @yui-knk
    yui-knk committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    821a5a1 View commit details
    Browse the repository at this point in the history