Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ruby objects from numeric node comparison #10079

Closed
wants to merge 1 commit into from
Closed

Remove ruby objects from numeric node comparison #10079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 20 additions & 0 deletions node.c
View file
Open in desktop
Expand Up @@ -176,6 +176,12 @@ parser_string_free(rb_ast_t *ast, rb_parser_string_t *str)
xfree(str);
}

static void
parser_bigfree(rb_ast_t *ast, rb_parser_bignum_t *big)
{
rb_parser_bigfree(xfree, big);
}

static void
free_ast_value(rb_ast_t *ast, void *ctx, NODE *node)
{
Expand Down Expand Up @@ -209,17 +215,31 @@ free_ast_value(rb_ast_t *ast, void *ctx, NODE *node)
parser_string_free(ast, RNODE_FILE(node)->path);
break;
case NODE_INTEGER:
parser_bigfree(ast, RNODE_INTEGER(node)->hash.data.ptr);
xfree(RNODE_INTEGER(node)->val);
break;
case NODE_FLOAT:
xfree(RNODE_FLOAT(node)->val);
break;
case NODE_RATIONAL:
parser_bigfree(ast, RNODE_RATIONAL(node)->hash.data.ptr);
xfree(RNODE_RATIONAL(node)->val);
break;
case NODE_IMAGINARY:
switch (RNODE_IMAGINARY(node)->type) {
case integer_literal:
case rational_literal:
parser_bigfree(ast, RNODE_IMAGINARY(node)->hash.data.ptr);
break;
case float_literal:
/* noop */
break;
}
xfree(RNODE_IMAGINARY(node)->val);
break;
case NODE_LINE:
parser_bigfree(ast, RNODE_LINE(node)->hash.data.ptr);
break;
default:
break;
}
Expand Down