Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock turbo_tests to 2.1.0 provisionally #10496

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

nobu
Copy link
Member

@nobu nobu commented Apr 10, 2024

turbo_tests 2.1.1 adds json to its dependency and the current bundler does not take the standard library json and fails to build as a gem before the installation.

turbo_tests 2.1.1 adds json to its dependency and the current bundler
does not take the standard library json and fails to build as a gem
before the installation.
@matzbot matzbot merged commit d60b2ca into ruby:master Apr 10, 2024
93 of 98 checks passed
@ilyazub
Copy link
Contributor

ilyazub commented Apr 16, 2024

I'm sorry for introducing this issue with turbo_tests. We'll remove the json dependency.

Just documenting the commands/pristine_spec.rb failure to be able to verify verify the fix later.

$ make test-bundler-parallel BUNDLER_SPECS=commands/pristine_spec.rb
# ...omitted
Invoking `/omitted/path/ruby/build/ruby -I/omitted/path/ruby/spec/bundler -r/omitted/path/ruby/spec/bundler/support/artifice/fail.rb -r/omitted/path/ruby/spec/bundler/support/hax.rb /omitted/path/ruby/tmp/1/gems/system/bin/bundle pristine` failed with output:
----------------------------------------------------------------------
Cannot pristine bar (1.0). Gem is sourced from local path.
Cannot pristine baz (1.0.0). Gem is sourced from local path.
The installation path is insecure. Bundler cannot continue.
/omitted/path/ruby/tmp/1/gems/system/extensions/x86_64-linux/3.4.0+0-static is world-writable (without sticky bit).
Bundler cannot safely replace gems in world-writeable directories due to potential vulnerabilities.
Please change the permissions of this directory or choose a different install path.
Installing very_simple_binary 1.0 with native extensions
Installing baz-dev 1.0.0
Installing weakling 1.0
----------------------------------------------------------------------
# ./spec/bundler/support/helpers.rb:208:in 'Spec::Helpers#sys_exec'
# ./spec/bundler/support/helpers.rb:121:in 'Spec::Helpers#bundle'
# ./spec/bundler/commands/pristine_spec.rb:122:in 'block (3 levels) in <top (required)>'
# ./spec/bundler/spec_helper.rb:106:in 'block (4 levels) in <top (required)>'
# ./spec/bundler/spec_helper.rb:106:in 'block (3 levels) in <top (required)>'
# ./spec/bundler/support/helpers.rb:339:in 'block in Spec::Helpers#with_gem_path_as'
# ./spec/bundler/support/helpers.rb:353:in 'Spec::Helpers#without_env_side_effects'
# ./spec/bundler/support/helpers.rb:334:in 'Spec::Helpers#with_gem_path_as'
# ./spec/bundler/spec_helper.rb:105:in 'block (2 levels) in <top (required)>'

ilyazub added a commit to serpapi/ruby that referenced this pull request Apr 16, 2024
commands/pristine_spec.rb is passed with the turbo_tests 2.2.3 because it the removed json dependency.

Related to ruby#10496
Related to d60b2ca
ilyazub referenced this pull request Apr 18, 2024
Ruby-core CI is having issues with turbo_tests 2.2.1. This version adds
json as a dependency and the `bundle install` command ruby-core uses is
not able to compile it for some reason.

I was not able to reproduce the issue locally, so this needs more
investigation.

We're already locked to 2.2.0, but ruby-core does not use a
`Gemfile.lock` so we need to lock explicitly in the Gemfile for now.
matzbot pushed a commit that referenced this pull request Apr 18, 2024
commands/pristine_spec.rb is passed with the turbo_tests 2.2.3 because it the removed json dependency.

Related to #10496
Related to d60b2ca
hsbt pushed a commit to rubygems/rubygems that referenced this pull request Apr 19, 2024
commands/pristine_spec.rb is passed with the turbo_tests 2.2.3 because it the removed json dependency.

Related to ruby/ruby#10496
Related to d60b2caa95b01f37d35db9ef8be1d035d14b408d
artur-intech pushed a commit to artur-intech/ruby that referenced this pull request Apr 26, 2024
commands/pristine_spec.rb is passed with the turbo_tests 2.2.3 because it the removed json dependency.

Related to ruby#10496
Related to d60b2ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants