Update turbo_tests to 2.2.3 or higher #10547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commands/pristine_spec.rb is passed with the turbo_tests 2.2.3 because it the removed json dependency. Related to ruby#10496 Related to d60b2ca
ilyazub
referenced
this pull request
Apr 18, 2024
Ruby-core CI is having issues with turbo_tests 2.2.1. This version adds json as a dependency and the `bundle install` command ruby-core uses is not able to compile it for some reason. I was not able to reproduce the issue locally, so this needs more investigation. We're already locked to 2.2.0, but ruby-core does not use a `Gemfile.lock` so we need to lock explicitly in the Gemfile for now.
|
@ilyazub Thanks! |
hsbt
approved these changes
Apr 18, 2024
|
I pushed this PR at b7c4c88 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commands/pristine_spec.rbis passed successfully with the turbo_tests 2.2.3 because it removed thejsondependency.Related to #10496