Brace expansion possible edge case fix #1061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are closing braces '}' before a open brace '{' it must be
ignored and considered as literal.
guilherme
changed the title
guilherme
changed the title
sonots
pushed a commit
to sonots/ruby
that referenced
this pull request
Nov 17, 2015
* dir.c (ruby_brace_expand): glob brace expansion edge case fix.
When there are closing braces '}' before a open brace '{' it
must be ignored and considered as literal.
[ruby-core:71138] [Bug ruby#11609]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52212 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are closing braces '}' before a open brace '{' it must be ignored and considered as literal otherwise the brace expansion won't work properly.
This make the brace expansion more robust since it make the brace expansion work with files that starts with closing braces.
I hope to cover all the cases. I'm not sure if i should put a test case for the File.fnmatch with the File::FNM_EXTGLOB option and if there are more side effects than File.fnmatch.