retry on cancelling of getaddrinfo
#11037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the registerred unblock function is called, it should retry the cancelled blocking function if possible after checkints. For example, `SIGCHLD` can cancel this method, but it should not raise any exception if there is no trap handlers. The following is repro-code: ```ruby require 'socket' PN = 10_000 1000000.times{ p _1 PN.times{ fork{ sleep rand(0.3) } } i = 0 while i<PN cpid = Process.wait -1, Process::WNOHANG if cpid # p [i, cpid] i += 1 end begin TCPServer.new(nil, 0).close rescue p $! exit! end end } ```
|
For example, trap(:USR1){ task }
blocking_operationIn this case, BTW |
mame
requested changes
Jun 21, 2024
| @@ -511,7 +511,7 @@ rb_getaddrinfo(const char *hostp, const char *portp, const struct addrinfo *hint | |||
| if (err == 0) *ai = arg->ai; | |||
| } | |||
| else if (arg->cancelled) { | |||
| err = EAI_AGAIN; | |||
| retry = 1; | |||
There was a problem hiding this comment.
Suggested change
| retry = 1; | |
| // If canceled due to signal delivery, we need to retry the process after the trap handler is executed. | |
| retry = 1; |
| @@ -734,7 +734,7 @@ rb_getnameinfo(const struct sockaddr *sa, socklen_t salen, | |||
| } | |||
| } | |||
| else if (arg->cancelled) { | |||
| err = EAI_AGAIN; | |||
| retry = 1; | |||
There was a problem hiding this comment.
Suggested change
| retry = 1; | |
| // If canceled due to signal delivery, we need to retry the process after the trap handler is executed. | |
| retry = 1; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the registerred unblock function is called, it should retry the cancelled blocking function if possible after checkints.
For example,
SIGCHLDcan cancel this method, but it should not raise any exception if there is no trap handlers.The following is repro-code: