drop FreeBSD < 4 support #1339
Closed
drop FreeBSD < 4 support #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we drop the support of older FreeBSD first? |
|
@nobu: What do you mean? Maybe the title is misleading and I should have written |
|
Removing these lines causes test failures. |
|
@nobu Can you point us to the exact test failures this would cause? I think |
The most recent version affected by this is 3.5 and was released in 2000. https://www.freebsd.org/releases/3.5R/announce.html https://en.wikipedia.org/wiki/History_of_FreeBSD#Version_history
cremno
force-pushed
the
remove-ifs-for-old-freebsd
branch
from
fd4b845
to
4cdad2f
Compare
cremno
changed the title
|
I've updated the title and added a NEWS entry. Hopefully my intent is more clear now. If these changes causes tests to fail, I'll fix them. But I believe @knu is correct. |
|
No specific tests may exist. Only I found is the ChangeLog for 1.4.0: |
nobu
referenced
this pull request
May 14, 2016
* NEWS: drop FreeBSD < 4 support. The most recent version affected by this is 3.5 and was released in 2000. https://www.freebsd.org/releases/3.5R/announce.html https://en.wikipedia.org/wiki/History_of_FreeBSD#Version_history git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent version affected by this is 3.5 and was released in 2000.
https://www.freebsd.org/releases/3.5R/announce.html
https://en.wikipedia.org/wiki/History_of_FreeBSD#Version_history