Fixed bug: Using 'open-uri' with 'tempfile' causes an exception. #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
reviewed
Aug 15, 2017
test/open-uri/test_open-uri.rb
Outdated
| @@ -120,6 +120,7 @@ def test_tempfile_rest_parameter | |||
| assert_nothing_raised { | |||
| temp_file = Tempfile.new | |||
| open(temp_file, 'a') | |||
| temp_file.close | |||
nobu
reviewed
Aug 16, 2017
test/open-uri/test_open-uri.rb
Outdated
| temp_file = Tempfile.new | ||
| assert_nothing_raised { open(temp_file, 'a') } | ||
| ensure | ||
| temp_file.close |
zammad-sync
pushed a commit
to zammad/zammad
that referenced
this pull request
Aug 16, 2017
…pull request #1675. Using 'open' with a temp file causes an exception. This is caused by the newly introduced Exchange integration dependencies 'viewpoint' and 'autodiscover' which depend on 'httpclient' which requires 'open-uri' somewhere. These cause the integration tests to fail - namely UserAgentTest#test_check_request. Link: ruby/ruby#1675
|
As we don't accept patches on maintenance branches directly, please rebase on the trunk, and file an issue at https://bugs.ruby-lang.org/projects/ruby-trunk/issues/new. And, I'm uncertain if it's better to check by the arity of diff --git i/lib/open-uri.rb w/lib/open-uri.rb
index ce608a9296..b445b7bca5 100644
--- i/lib/open-uri.rb
+++ w/lib/open-uri.rb
@@ -27,7 +27,18 @@
# We can accept URIs and strings that begin with http://, https:// and
# ftp://. In these cases, the opened file object is extended by OpenURI::Meta.
def open(name, *rest, &block) # :doc:
- if name.respond_to?(:open) && !name.method(:open).parameters.empty?
+ if name.respond_to?(:to_io)
+ io = name.to_io.dup
+ if block
+ begin
+ yield io
+ ensure
+ io.close
+ end
+ else
+ io
+ end
+ elsif name.respond_to?(:open)
name.open(*rest, &block)
elsif name.respond_to?(:to_str) &&
%r{\A[A-Za-z][A-Za-z0-9+\-\.]*://} =~ name && |
|
Closing. Applied changed and feedback in #1680 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
try this in your current ruby env:
Get this:
Greetings.