Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug: Using 'open-uri' with 'tempfile' causes an exception. #1675

Closed
wants to merge 4 commits into from
Closed

Fixed bug: Using 'open-uri' with 'tempfile' causes an exception. #1675

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3459f2a
Fixed bug: Using 'open-uri' with 'tempfile' causes an exception.
thorsteneckel Aug 15, 2017
a5c0932
Follow up: Fixed 'Leaked file descriptor' issue in CI env.
thorsteneckel Aug 15, 2017
824cf45
Follow up: Work in feedback to ensure closed filehandle. Thanks to @n…
thorsteneckel Aug 15, 2017
e788db9
Follow up: Switched to .close! as requested by @nobu.
thorsteneckel Aug 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions test/open-uri/test_open-uri.rb
View file
Open in desktop
Expand Up @@ -120,6 +120,7 @@ def test_tempfile_rest_parameter
assert_nothing_raised {
temp_file = Tempfile.new
open(temp_file, 'a')
temp_file.close
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use ensure.

}
end

Expand Down