Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly parse all allowed iTunes RSS explicit field values #1715

Closed

Conversation

valeriecodes
Copy link

Per the iTunes spec: https://help.apple.com/itc/podcasts_connect/#/itcb54353390

If you specify yes, explicit, or true, indicating the presence of explicit content, the iTunes Store displays an Explicit parental advisory graphic for your podcast.

If you specify clean, no, or false, indicating that none of your podcast episodes contain explicit language or adult content, the iTunes Store displays a Clean parental advisory graphic for your podcast.

Currently the parser only handles the values of true or yes for explicit and false or clean for clean.

@amatsuda amatsuda requested a review from kou October 22, 2017 01:20
@kou
Copy link
Member

kou commented Oct 22, 2017

Ah, sorry. I missed this.
I fixed this with other implementation. The spec says yes, explicit, true, clean, no and false are valid values but your change supports only explicit, yes, clean and no.

Thanks for your report. I didn't notice it when I added <itunes:> support.

@kou kou closed this Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants