-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement String#undump #1765
Closed
Closed
Implement String#undump #1765
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
16f60dd
first try to implement String#undump
tadd c2854d0
refactoring: extract last part of rb_strseq_index() to use in undump_…
tadd e8500b8
small refactoring
tadd a06e48c
refactoring: eliminate duplicate code
tadd b4bb1d1
add NEWS
tadd e9e6baf
"\\uNNNN".undump.encoding should be UTF-8 automatically
tadd 11687bf
raise if self is not wrapped with double quotes
tadd 80edc08
support `"...".force_encoding("...")` form
tadd d54933b
use RuntimeError instead of ArgumentError for invalid self form
tadd dea1081
cast explicitly from unsigned long to int to prevent clang error
tadd f8fd668
explicitly forbid to undump non-ascii character
tadd a280551
fix style
tadd 00dfe39
reject double quote in double quote
tadd c4f214c
add more tests for invalid escaping
tadd 4a39f9f
remove needless logic
tadd 670ad3a
adjust unescaped expression to parse.y
tadd ee2059c
forbid to undump string that contains NUL byte
tadd 5091b01
remove needless "const" to prevent VC warning
tadd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this function is extracted from
rb_strseq_index
because I needed to use this fromundump_after_backslash
too.