Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the dot-colon method reference frozen #2267

Merged
merged 7 commits into from
Aug 30, 2019
Merged

Make the dot-colon method reference frozen #2267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5417e7c
make the dot-colon method reference frozen
mensfeld Jul 2, 2019
ad97d98
Merge branch 'master' of https://github.com/ruby/ruby into frozen-dot…
mensfeld Jul 3, 2019
aab49b5
use assert_predicate instead of assert
mensfeld Jul 26, 2019
581d38a
use assert_not_predicate instead of assert_equal
mensfeld Jul 28, 2019
644fb31
Merge branch 'master' into gh-2267
k0kubun Aug 15, 2019
b997082
Merge branch 'master' into frozen-dot-colon-method-reference
mensfeld Aug 29, 2019
0396ec9
Merge branch 'master' into frozen-dot-colon-method-reference
hsbt Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion insns.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ checktype
ret = (TYPE(val) == (int)type) ? Qtrue : Qfalse;
}

/* get method reference. */
/* get frozen method reference. */
DEFINE_INSN
methodref
(ID id)
Expand Down
13 changes: 13 additions & 0 deletions test/ruby/test_method.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,6 +1141,19 @@ def o.method(m); nil; end
assert_nil(o.method(:foo))
end

def test_method_reference_freeze_state
m = 1.:succ
assert_predicate(m, :frozen?, "dot-symbol method reference should be frozen")
m = 1.method(:succ)
assert_not_predicate(m, :frozen?, "#method method reference should not be frozen")
o = Object.new
def o.foo; 42; end
m = o.:foo
assert_predicate(m, :frozen?, "dot-symbol method reference should be frozen")
m = o.method(:foo)
assert_not_predicate(m, :frozen?, "#method method reference should not be frozen")
end

def test_umethod_bind_call
foo = Base.instance_method(:foo)
assert_equal(:base, foo.bind_call(Base.new))
Expand Down