Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ec -> backtrace (internal) and use it to implement fiber backtrace #3422

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix requested review from nobu, shyouhei, eregon and ko1 and removed request for nobu August 15, 2020 03:37
@ioquatix
Copy link
Member Author

Need to add:

  • tests (here)
  • specs (in ruby/specs)

Copy link
Member

@shyouhei shyouhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

@ioquatix
Copy link
Member Author

I added some basic tests. If it passes, I'll merge it.

@ioquatix ioquatix merged commit 0a218a9 into ruby:master Aug 17, 2020
@ioquatix ioquatix deleted the fiber-backtrace branch August 17, 2020 12:56
@eregon
Copy link
Member

eregon commented Aug 17, 2020

specs (in ruby/specs)

FWIW they could be added directly here too under spec/ruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants