use me->def instead of me for opt_table #4493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ko1 I know you wanted to use this approach instead of #4376. However, this approach doesn't appear to handle all optimized methods correctly. Is this something you are still working on? Would you be opposed to merging #4376 now, and then switching to this approach later if the issues with this approach are fixed? |
`vm_opt_method_table` is me=>bop table to manage the optimized methods (by specialized instruction). However, `me` can be invalidated to invalidate the method cache entry. [Bug #17725] To solve the issue, use `me-def` instead of `me` which simply copied at invalidation timing. A test by @jeremyevans ruby#4376
Because the key of redefine table is `def`, `def` should be unique for each optimized method (`alias` is not allowed).
@jeremyevans Now tests seems passes. Do you have any other issues? |
|
I have no issues with this now that the tests pass. It's definitely simpler than the approach I used, so it makes sense to use this approach instead. I'll close #4376. |
|
Thank you for confirmation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vm_opt_method_tableis ame=>boptable to manage the optimizedmethods (by specialized instruction). However,
mecan be invalidatedto invalidate the method cache entry.
[Bug #17725]
To solve the issue, use
me-definstead ofmewhich simply copiedat invalidation timing.
A test by @jeremyevans #4376