Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use me->def instead of me for opt_table #4493

Merged
merged 2 commits into from
Jul 28, 2021
Merged

use me->def instead of me for opt_table #4493

merged 2 commits into from
Jul 28, 2021

Commits on Jul 28, 2021

  1. use me->def instead of me for opt_table 

    `vm_opt_method_table` is me=>bop table to manage the optimized
methods (by specialized instruction). However, `me` can be invalidated
to invalidate the method cache entry.
[Bug #17725]

To solve the issue, use `me-def` instead of `me` which simply copied
at invalidation timing.

A test by @jeremyevans ruby#4376
    @ko1
    ko1 committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    8007dc6 View commit details
    Browse the repository at this point in the history

  2. should not share same def for specialized method 

    Because the key of redefine table is `def`, `def` should be
unique for each optimized method (`alias` is not allowed).
    @ko1
    ko1 committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    ff28d35 View commit details
    Browse the repository at this point in the history