Actually ignore FNM_CASEFOLD flag in Dir.glob #4583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already documented as being ignored, but it wasn't being ignored, causing an issue in a particular case where a UTF-8 pattern was provided and a filename was tested that wasn't valid UTF-8. Fixes [Bug #14456]
lildude
added a commit
to github-linguist/linguist
that referenced
this pull request
Nov 13, 2022
* ci: drop ruby 2.5 * Add 3.1 * Implement case-insensitive glob pattern builder This is needed on 3.1 onwards as `FNM_CASEFOLD` is no longer honoured on 3.1 as of ruby/ruby#4583 which brings the `Dir.glob` behaviour inline with what the https://docs.ruby-lang.org/en/3.1/File/File/Constants.html#FNM_CASEFOLD have been saying for years. Co-authored-by: Colin Seymour <colin@github.com>
|
This was the only way to get Dir.glob to work case insensitively, it might have been documented this way but there were plenty of people using it. Now caused frustrating bug in our app. And the workaround is nasty: |
tpendragon
added a commit
to pulibrary/figgy
that referenced
this pull request
Apr 7, 2023
ruby/ruby#4583 made FNM_CASEFOLD no longer work in Dir.glob (it was documented as such for years), so we have to iterate and filter.
tpendragon
added a commit
to pulibrary/figgy
that referenced
this pull request
Apr 7, 2023
ruby/ruby#4583 made FNM_CASEFOLD no longer work in Dir.glob (it was documented as such for years), so we have to iterate and filter.
tpendragon
added a commit
to pulibrary/figgy
that referenced
this pull request
Apr 7, 2023
ruby/ruby#4583 made FNM_CASEFOLD no longer work in Dir.glob (it was documented as such for years), so we have to iterate and filter.
tpendragon
added a commit
to pulibrary/figgy
that referenced
this pull request
Apr 10, 2023
ruby/ruby#4583 made FNM_CASEFOLD no longer work in Dir.glob (it was documented as such for years), so we have to iterate and filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already documented as being ignored, but it wasn't being
ignored, causing an issue in a particular case where a UTF-8
pattern was provided and a filename was tested that wasn't valid
UTF-8.
Fixes [Bug #14456]