Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include/ruby/atomic.h: rework #4848

Merged
merged 2 commits into from
Sep 22, 2021
Merged

include/ruby/atomic.h: rework #4848

merged 2 commits into from
Sep 22, 2021

Conversation

shyouhei
Copy link
Member

Reduce macros to do the same things in inline functions instead. This way assertions can be made granular.

Reduce macros to do the same things in inline functions instead.  This
way assertions can be made granular.
@shyouhei
Copy link
Member Author

#4835 made me feel that the header file has unnecessary number of preprocessor macros. This pull request shall remedy.

I observed CI failures.
https://github.com/ruby/ruby/actions/runs/1240165911

It turns out that  RBIMPL_ATTR_NOALIAS was not mature before.  Skip
using it for old clang, and everything work as expected.
@shyouhei shyouhei merged commit 0dea31c into ruby:master Sep 22, 2021
@shyouhei shyouhei deleted the update-atomic branch September 22, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant