Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Enable out of memory tests #5214

Merged
merged 1 commit into from
Dec 4, 2021
Merged

YJIT: Enable out of memory tests #5214

merged 1 commit into from
Dec 4, 2021

Conversation

XrXr
Copy link
Member

@XrXr XrXr commented Dec 4, 2021 •
edited 

As of [1] and [2], YJIT has enough support for out of memory conditions
to pass these two basic tests.

OOM code paths are prone to bugs since they are rarely exercised in
common workloads. We might want to add CI runs that stress test these
code paths. Maybe outside of GitHub Actions for capacity reasons.


[1]: f41b4d44f95978dfa97af04af00055dc3fbf7978
[2]: b5b6ab4194f16e96ee5004288cc469ac1bca41a3

@XrXr
YJIT: Enable out of memory tests
f753bd0 
As of [1] and [2], YJIT has enough support for out of memory conditions
to pass these two basic tests.

OOM code paths are prone to bugs since they are rarely exercised in
common workloads. We might want to add CI runs that stress test these
code paths. Maybe outside of GitHub Actions for capacity reasons.

[1]: f41b4d4
[2]: b5b6ab4
@XrXr XrXr merged commit 34b5e25 into ruby:master Dec 4, 2021
@XrXr XrXr deleted the enable-yjit-oom-tests branch December 4, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximecb maximecb Awaiting requested review from maximecb

@tenderlove tenderlove Awaiting requested review from tenderlove

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@XrXr