[DOC] Document Marshal#load parameter freeze:
#5332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@byroot Please review |
byroot
approved these changes
Dec 23, 2021
zverok
force-pushed
the
docs-fix-marshal-load
branch
from
2ba127d
to
17549f2
Compare
nobu
reviewed
Dec 24, 2021
Comment on lines
+19
to
+31
| # serialized = Marshal.dump(['value1', 'value2', 'value1', 'value2']) | ||
| # | ||
| # deserialized = Marshal.load(serialized) | ||
| # deserialized.map(&:frozen?) | ||
| # # => [false, false, false, false] | ||
| # deserialized.map(&:object_id) | ||
| # # => [1023900, 1023920, 1023940, 1023960] -- 4 different objects | ||
| # | ||
| # deserialized = Marshal.load(serialized, freeze: true) | ||
| # deserialized.map(&:frozen?) | ||
| # # => [true, true, true, true] | ||
| # deserialized.map(&:object_id) | ||
| # # => [1039360, 1039380, 1039360, 1039380] -- only 2 different objects, object_ids repeating |
There was a problem hiding this comment.
These lines seem indented more than above call-seq, intentional?
zverok
force-pushed
the
docs-fix-marshal-load
branch
from
17549f2
to
78197ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot:
