Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced RDoc for IO #5424

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Enhanced RDoc for IO #5424

merged 1 commit into from
Jan 10, 2022

Conversation

BurdetteLamar
Copy link
Member

Treats:

  • #sysseek
  • #syswrite
  • #sysread

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label Jan 10, 2022
jeremyevans
jeremyevans requested changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small change requested. OK to commit after than change with additional review.

io.c
* f.syswrite(30) # => 2
* f.syswrite(:foo) # => 3
*
* This methods should not be used with other stream-writer methods.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This methods -> This method

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@BurdetteLamar BurdetteLamar merged commit 6931d70 into ruby:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyevans jeremyevans jeremyevans requested changes

Assignees
No one assigned
Labels
Documentation Improvements to documentation.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BurdetteLamar @jeremyevans