Testing read_nonblock on a partial TLS record results in IO::WaitReadable #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmasaki
pushed a commit
to mmasaki/ruby
that referenced
this pull request
Jun 22, 2014
a partial TLS record results in IO::WaitReadable by @mohamedhafez. [fix rubyGH-547] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46087 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
markjlorenz
pushed a commit
to covermymeds/ruby
that referenced
this pull request
Jun 30, 2014
a partial TLS record results in IO::WaitReadable by @mohamedhafez. [fix rubyGH-547] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46087 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been an open issue in JRuby (jruby/jruby#1280) caused by read_nonblock spinning indefinitely when only a partial TLS record is available. JRuby syncs their openssl tests from the main ruby repo, so I thought I'd issue this pull request here to add the test for MRI as well. MRI already handles this case correctly.