Fixes for CSV Header Conversion

[sshaw]

1st commit: don't try to encode nil headers. Currently this causes:

NoMethodError: undefined method `encode' for nil:NilClass

2nd commit: just makes sense for this converter, I think. Currently leading/trailing whitespace will create: :_symbol_header or :symbol_header_.

[zzak]

cc @JEG2

[JEG2]

I think adding the strip() call is pretty safe. It does technically change the results you would get with certain files, but I think it's probably for the better.

I'm less sure swallowing the nil headers. If we do that, it rules out the possibility of writing a converter that changes nil headers into what you would like them to be.

Thoughts?

[sshaw]

I'm less sure swallowing the nil headers.
... it rules out the possibility of writing a converter that changes nil headers into what you would like them to be.

True, but what's the use case? Not much context is provided for nil headers. One could append a counter to the generated name (how would one then make the relation between the auto generated name and its values) or use a constant value as a catch-all.

That aside, the current code (NoMethodError aside) doesn't necessarily accommodate this. One would either have to put their converter before the builtins or the builtins would have to convert nil to a String to prevent header processing from being halted.

[JEG2]

You convinced me. I applied both of your changes.

Thank you.