-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for CSV Header Conversion #575
Conversation
cc @JEG2 |
I think adding the I'm less sure swallowing the Thoughts? |
True, but what's the use case? Not much context is provided for That aside, the current code ( |
You convinced me. I applied both of your changes. Thank you. |
Reported by Skye Shaw [Fixes rubyGH-575] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@45498 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
* lib/csv.rb: Update documentation of CSV header converter for r45498, [rubyGH-575]. [Fix rubyGH-1215] git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@53628 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
(ruby/irb#615) This makes sure `Context#evaluate` really just evaluates the input. It will also make #575's implementation cleaner.
1st commit: don't try to encode
nil
headers. Currently this causes:2nd commit: just makes sense for this converter, I think. Currently leading/trailing whitespace will create:
:_symbol_header
or:symbol_header_
.