libyjit dependency #6371
Merged
libyjit dependency #6371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, miniruby is rebuild **always** when yjit is enabled, even if nothing is changed.
k0kubun
reviewed
Sep 14, 2022
k0kubun
reviewed
Sep 14, 2022
k0kubun
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now even if libyjit.a is up to date, it will be tried to rebuild unconditionally.
That means all targets depending on it, such as miniruby and its dependents, have to rebuild too.
This PR assumes it just depends on the yjit sources and Cargo files.