YJIT: Instrument global allocations on stats build #6712
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For stats build, this PR allows you to measure how much memory YJIT uses in Rust.
Enabling YJIT currently consumes a lot more memory than what's used for code pages. I think it's nice to monitor changes in allocated bytes before attempting to reduce it because some changes could come at the cost of implementation complexity and we shouldn't do it when it's not really effective.
Example
The current state of 25 itrs on railsbench:
When 9.7MB is used for JIT code, 25.1MB is used for Rust's global allocations.
Benchmark
Its performance impact on stats build seems negligible. Here's the yjit-bench result on railsbench.
Before
After