Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YJIT: Remove unused src_ctx from Block #6714

Merged
merged 1 commit into from Nov 13, 2022
Merged

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Nov 11, 2022

Pairing with Maxime and Alan, we found that we don't use src_ctx and removing this contributes to reducing memory usages. This PR removes the unused field.

With yjit_alloc_size implemented in #6712, I confirmed it has the following memory usage impact on 25 itrs of railsbench:

Before

inline_code_size:         4948216
outlined_code_size:       4947968
freed_code_size:                0
yjit_alloc_size:         25137225

JIT code: 9.8MB, payload: 25.1MB

After

inline_code_size:         4852292
outlined_code_size:       4850940
freed_code_size:                0
yjit_alloc_size:         23306197

JIT code: 9.7MB, payload: 23.3MB

(*_code_size changes would be just an unrelated fluctuation, but I included it for comparison to yjit_alloc_size)

@matzbot matzbot requested a review from a team November 11, 2022 01:30
@maximecb maximecb merged commit d5e1b82 into ruby:master Nov 13, 2022
@maximecb maximecb deleted the yjit-src-ctx branch November 13, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants